Skip to main content

Top Down vs Bottom Up

Top down development has you starting at the highest point in the application that you can. From here you code down until there is nothing else left to develop. Once you reach this point you should be code complete. Along the way you may need to stub out areas that have not yet been created, or designed.

Bottom up development has you starting at the lowest point in the application. The idea being that this part of the application has the most complexity or will be the most important. You will build the system up from a series of smaller components.

Top down development and bottom up development was introduced to myself in my early days of university. At the time the distinction didn't really mean much - I was very much a developer who would work from the bottom up.

Over time I have completely switched my stance on this. I believe agile practices and TDD are the reason for this change. I feel so strongly about this that I would go as far as to claim that within an agile team - bottom up development is an anti pattern.

Consider the following tasks to be completed on a team of four developers.

  • Create controller - main entry point, request mapping.
  • Create service - service layer, simple business logic.
  • Database query - thin wrapper around complex DB query.

With a bottom up approach a pair of developers could work on the complex database query. After some time they would have this working. The other two developers could start with the controller or service.

The problem with this approach comes from the painful integration process. The developers working on the service might be coding against the interface the team discussed during a planning session, while the developers on the query may have had to change their approach.

This example is trivial, but imagine a story with thirty tasks, more developers and more complexity and this bottom up approach is difficult. Over the past few years my top down approach has evolved.

My first step would be to stub out the workflow with the above implementation. There is no real logic here - only the objects collaboration is implemented. At this stage there are no tests, TDD would not be used. After all there is no logic here. The code is so simple it can be reasoned about with peer review, planning sessions and so on.

At this stage all of the tasks are open for any developer to pick up. If a breaking change was required, there would be no way for one pair to commit these changes without the other pair knowing. Another benefit of this approach is that an end to end acceptance test could be wrapped around the functionality from the get go.

As part of these tasks each developer would use TDD. Remember no tests exist at this point. Building up the tests in stages would ensure the logic of how the objects collaborate is preserved, and ensures that the actual domain logic that is implemented is correct. Does this mean we aren't doing TDD? No, of course not. The tests will drive the implementation. If we need to introduce new objects that is fine - these simply become implementation details that the other devs need not worry about as long as the workflow is not broken.

This approach to top down development isn't new, though many don't appreciate its benefits. I plan on expanding on this style of pragmatic TDD in the coming months.

Comments

Popular posts from this blog

Constant Object Anti Pattern

Most constants are used to remove magic numbers or variables that lack context. A classic example would be code littered with the number 7. What does this refer to exactly? If this was replaced with DaysInWeek or similar, much clarity is provided. You can determine that code performing offsets would be adding days, rather than a mysterious number seven.Sadly a common pattern which uses constants is the use of a single constant file or object. The beauty of constants is clarity, and the obvious fact such variables are fixed. When a constant container is used, constants are simply lumped together. These can grow in size and often become a dumping ground for all values within the application.A disadvantage of this pattern is the actual value is hidden. While a friendly variable name is great, there will come a time where you will want to know the actual value. This forces you to navigate, if only to peek at the value within the constant object. A solution is to simple perform a refactor …

Three Steps to Code Quality via TDD

Common complaints and problems that I've both encountered and hear other developers raise when it comes to the practice of Test Driven Development are: Impossible to refactor without all the tests breakingMinor changes require hours of changes to test codeTest setup is huge, slow to write and difficult to understandThe use of test doubles (mocks, stubs and fakes is confusing)Over the next three posts I will demonstrate three easy steps that can resolve the problems above. In turn this will allow developers to gain one of the benefits that TDD promises - the ability to refactor your code mercifully in order to improve code quality.StepsStop Making Everything PublicLimit the Amount of Dependencies you Use A Unit is Not Always a Method or ClassCode quality is a tricky subject and highly subjective, however if you follow the three guidelines above you should have the ability to radically change implementation details and therefore improve code quality when needed.

DRY vs DAMP in Tests

In the previous post I mentioned that duplication in tests is not always bad. Sometimes duplication becomes a problem. Tests can become large or virtually identically excluding a few lines. Changes to these tests can take a while and increase the maintenance overhead. At this point, DRY violations need to be resolved.SolutionsTest HelpersA common solution is to extract common functionality into setup methods or other helper utilities. While this will remove and reduce duplication this can make tests a bit harder to read as the test is now split amongst unrelated components. There is a limit to how useful such extractions can help as each test may need to do something slightly differently.DAMP - Descriptive and Meaningful PhrasesDescriptive and Meaningful Phrases is the alter ego of DRY. DAMP tests often use the builder pattern to construct the System Under Test. This allows calls to be chained in a fluent API style, similar to the Page Object Pattern. Internally the implementation wil…