Skip to main content

Throw Code Away

The third and final part of my agile architecture series.


Part one suggested walking skeletons for new features or projects. Part two suggested building the limited, smallest and simplest functionality possible. However you do not always have the luxury of deferral. Likewise if the project already exists and you are amending functionality, a walking skeleton is going to be limited.

Solution

Throw code away. This sounds brutal and overkill, but throwing code away has many advantages.

Benefits

  • The second time around you will solve the problem quicker having benefited from first time. The first attempt is a prototype in this case. Throwing away prototypes is expected. They are not production ready, usually built with short cuts or quality comprises intentionally.

  • The cleanest code is no code. Your following attempts will be cleaner. Knowing the issues from the previous attempt allows the ability to put code and procedures in place to prevent the same quality problems occurring.

  • Long term goals can be achieved rather than aiming for short term wins. Instead of focusing on meeting the current iterations' goal, answer whether or not your solution is fit for purpose going forwards. Does it scale? Is the quality there?

  • You benefit from hindsight. Most code to be replaced should have lived through some sort of review process. If the code has lived through production you have even more ammo to target the weak points. Where are the hotspots? What changes more frequently? Where do bugs tend to reside?

Objections

Throwing code away should not be taken lightly, but it is certainly a valid technique under the right circumstances.

You will have an easier time suggesting to start over on two days worth of work than you would two weeks, two months or two years. Keep your batch sizes small and the ability to throw code away will become easier to accept, with the benefits outweighing the negatives.

Small batches are not the only prerequisite to suggest throwing code away. Small changes are also essential. You can easily suggest throwing a method or class away, but you will rightly so have a harder time suggesting throwing away a module or system.

Refactoring is often used as a suggestion to combat the need to rewrite or throw code away but this is rarely the case in practice. Refactoring is a misused word and crucially misunderstood technique. If you change architecture you are not refactoring.

The biggest objector you will likely find is yourself. Having become invested in a task it can be hard to try again. Fight the urge to resist and throw code away. You may be pleasantly surprised by the results.

Comments

Popular posts from this blog

Three Steps to Code Quality via TDD

Common complaints and problems that I've both encountered and hear other developers raise when it comes to the practice of Test Driven Development are: Impossible to refactor without all the tests breakingMinor changes require hours of changes to test codeTest setup is huge, slow to write and difficult to understandThe use of test doubles (mocks, stubs and fakes is confusing)Over the next three posts I will demonstrate three easy steps that can resolve the problems above. In turn this will allow developers to gain one of the benefits that TDD promises - the ability to refactor your code mercifully in order to improve code quality.StepsStop Making Everything PublicLimit the Amount of Dependencies you Use A Unit is Not Always a Method or ClassCode quality is a tricky subject and highly subjective, however if you follow the three guidelines above you should have the ability to radically change implementation details and therefore improve code quality when needed.

DRY vs DAMP in Tests

In the previous post I mentioned that duplication in tests is not always bad. Sometimes duplication becomes a problem. Tests can become large or virtually identically excluding a few lines. Changes to these tests can take a while and increase the maintenance overhead. At this point, DRY violations need to be resolved.SolutionsTest HelpersA common solution is to extract common functionality into setup methods or other helper utilities. While this will remove and reduce duplication this can make tests a bit harder to read as the test is now split amongst unrelated components. There is a limit to how useful such extractions can help as each test may need to do something slightly differently.DAMP - Descriptive and Meaningful PhrasesDescriptive and Meaningful Phrases is the alter ego of DRY. DAMP tests often use the builder pattern to construct the System Under Test. This allows calls to be chained in a fluent API style, similar to the Page Object Pattern. Internally the implementation wil…

Coding In the Real World

As a student when confronted with a problem, I would end up coding it and thinking - how do the professionals do this?For some reason I had the impression that once I entered the industry I would find enlightenment. Discovering the one true way to write high quality, professional code.It turns out that code in industry is not too far removed from the code I was writing back when I knew very little.Code in the real world can be:messy or cleanhard or easy to understandsimple or complexeasy or hard to changeor any combination of the aboveVery rarely will you be confronted with a problem that is difficult. Most challenges typically are formed around individuals and processes, rather than day to day coding. Years later I finally have the answer. Code in the real world is not that much different to code we were all writing when we first started out.If I could offer myself some advice back in those early days it would be to follow KISS, YAGNI and DRY religiously. The rest will fall into plac…

Feature Toggles

I'm a fan of regular releasing. My background and experience leads me to release as regularly as possible. There are numerous benefits to regular releases; limited risk, slicker release processes and the ability to change as requirements evolve.The problem with this concept is how can you release when features are not functionally complete?SolutionIf there is still work in progress, one solution to allow frequent releases is to use feature toggles. Feature toggles are simple conditional statements that are either enabled or disabled based on some condition.This simple example shows a feature toggle for an "Edit User" feature. If the boolean condition is false, then we only show the "New User" feature and the "Admin" feature. This boolean value will be provided by various means, usually a configuration file. This means at certain points we can change this value in order to demonstrate the "Edit User" functionality. Our demo environment could …

Reused Abstraction Principle

This is the second part of my series on abstractions.Part 1 - AbstractionsPart 3 - Dependency Elimination PrincipleThe Reused Abstraction Principle is a simple in concept in practice, but oddly rarely followed in typical enterprise development. I myself have been incredibly guilty of this in the past.Most code bases have a 1:1 mapping of interfaces to implementations. Usually this is the sign of TDD or automated testing being applied badly. The majority of these interfaces are wrong. 1:1 mappings between interfaces and implementations is a code smell.Such situations are usually the result of extracting an interface from an implementation, rather than having the client drive behaviour.These interfaces are also often bad abstractions, known as "leaky abstractions". As I've discussed previously, these abstractions tend to offer nothing more than simple indirection.ExampleApply the "rule of three". If there is only ever one implementation, then you don't need …